Merged
Conversation
HeadingProps 타입을 선언하고, 이를 props로 받는 컴포넌트를 마이그레이션 했습니다.
반응형 사이즈 theme을 추가했습니다. Styled-components에서 as로 받은 태그를 동적으로 설정하기 위해 구조를 변경했습니다. Heading 컴포넌트를 내보냈습니다.
theme 반응형 삭제
jhyj0521
added
🌟 feature
hustle-dev
reviewed
Mar 24, 2022
| import { HeadingProps } from './Heading.types'; | ||
| import { StyledHeading } from './Heading.styled'; | ||
|
|
||
| export const Heading = ({ as, className, children }: HeadingProps): JSX.Element => { |
Contributor
There was a problem hiding this comment.
className에 a11yHidden이 들어간경우를 제외하면 필요없을것 같다는 팀원들의 이야기가 있었음
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Related Issues
#18
What does this PR do?
Other information